Skip to content

Fix non-pattern package prefix check in CandidateComponentsIndex #35601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix non-pattern package prefix check in CandidateComponentsIndex #35601

wants to merge 1 commit into from
+1 −1

Conversation

@NeatGuyCoding
Copy link
Contributor

the non-pattern package prefix check uses packageName.startsWith(basePackage) which incorrectly treats "com.example2.foo" as a subpackage of "com.example"

@NeatGuyCoding
bugfix: the non-pattern package prefix check uses packageName.startsW…
9d16167 
…ith(basePackage) which incorrectly treats "com.example2.foo" as a subpackage of "com.example"

Signed-off-by: NeatGuyCoding <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 11, 2025
@bclozel bclozel added the in: core Issues in core modules (aop, beans, core, context, expression) label Oct 11, 2025
@sbrannen sbrannen self-assigned this Oct 11, 2025
@sbrannen sbrannen changed the title bugfix: fix the non-pattern package prefix check Fix non-pattern package prefix check in CandidateComponentsIndex Oct 11, 2025
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 11, 2025
@sbrannen sbrannen added this to the 7.0.0-RC1 milestone Oct 11, 2025
@sbrannen
Copy link
Member

Since this is a follow-up to #35497 (which has not yet been released), I've labeled this as as task instead of bug.

@sbrannen sbrannen closed this in 113b9d1 Oct 11, 2025
sbrannen added a commit that referenced this pull request Oct 11, 2025
@sbrannen
Introduce tests for CandidateComponentsIndex.hasScannedPackage()
b727dbb 
This indirectly tests the implementation of matchPackage(), which was
fixed in the previous commit.

See gh-35497
See gh-35601
@sbrannen
Copy link
Member

This has been merged into main in 113b9d1, and I added missing tests in b727dbb.

Thanks

@NeatGuyCoding NeatGuyCoding deleted the fix-package-check branch October 12, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sbrannen sbrannen

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task

Projects

None yet

Milestone

7.0.0-RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@NeatGuyCoding @sbrannen @bclozel @spring-projects-issues